This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Add example: Combobox with list store #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ski0090
force-pushed
the
feacture/add_example
branch
2 times, most recently
from
c7b5d58 to
c249a51
Compare
|
Apart from my comments and the clippy lint, looks good to me. |
@GuillaumeGomez That's from old code and a new clippy lint, and because we always use latest beta this now triggers for an unrelated PR. Want to send a PR to fix the clippy lint? |
ski0090
force-pushed
the
feacture/add_example
branch
from
c249a51 to
7ca96a4
Compare
@GuillaumeGomez @sdroege thanks for the review |
ski0090
force-pushed
the
feacture/add_example
branch
from
7ca96a4 to
441ac47
Compare
ski0090
force-pushed
the
feacture/add_example
branch
from
441ac47 to
2f595d6
Compare
|
@bilelmoussaoui Opinion applied. thanks for the review |
ski0090
force-pushed
the
feacture/add_example
branch
from
2f595d6 to
d36b252
Compare
ski0090
force-pushed
the
feacture/add_example
branch
from
d36b252 to
d4db92b
Compare
|
@GuillaumeGomez @bilelmoussaoui Can i merge? |
GuillaumeGomez
approved these changes
Dec 5, 2023
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example that utilizes Liststore in Combobox.