Skip to content

Commit

Permalink
backupccl: "skip" TestChangefeedRestartDuringBackfill
Browse files Browse the repository at this point in the history
under span configs. This test flakes pretty reliably after span configs
were enabled (cockroachdb#73876). Investigating this further is being tracked in
\cockroachdb#75080; lets have this test use the old subsystem for now (only down in
KV; we've narrowed down the failure to having something to do with
concurrent range splits, within the tenant keyspace, while a changefeed
is declared).

Release note: None
  • Loading branch information
irfansharif authored and Gerardo Torres committed Jan 24, 2022
1 parent 878c632 commit e96c8bf
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions pkg/ccl/changefeedccl/changefeed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -394,12 +394,12 @@ func TestChangefeedFullTableName(t *testing.T) {
assertPayloads(t, foo, []string{`d.public.foo: [1]->{"after": {"a": 1, "b": "a"}}`})
})
}
//TODO(zinger): Plumb this option through to all encoders so it works in sinkless mode
//t.Run(`sinkless`, sinklessTest(testFn))
// TODO(zinger): Plumb this option through to all encoders so it works in sinkless mode
// t.Run(`sinkless`, sinklessTest(testFn))
t.Run(`enterprise`, enterpriseTest(testFn))
t.Run(`kafka`, kafkaTest(testFn))
t.Run(`webhook`, webhookTest(testFn))
//t.Run(`pubsub`, pubsubTest(testFn))
// t.Run(`pubsub`, pubsubTest(testFn))
}

func TestChangefeedMultiTable(t *testing.T) {
Expand Down Expand Up @@ -2417,7 +2417,7 @@ func TestChangefeedTruncateOrDrop(t *testing.T) {
t.Run(`kafka`, kafkaTest(testFn))
t.Run(`webhook`, webhookTest(testFn))
t.Run(`pubsub`, pubsubTest(testFn))
//will sometimes fail, non deterministic
// will sometimes fail, non deterministic
}

func TestChangefeedMonitoring(t *testing.T) {
Expand Down Expand Up @@ -4102,7 +4102,15 @@ func TestChangefeedRestartDuringBackfill(t *testing.T) {
})
}

t.Run(`kafka`, kafkaTest(testFn))
useSysCfgInKV := withKnobsFn(func(knobs *base.TestingKnobs) {
// TODO(irfansharif): This test is "skipped" under span configs;
// #75080.
if knobs.Store == nil {
knobs.Store = &kvserver.StoreTestingKnobs{}
}
knobs.Store.(*kvserver.StoreTestingKnobs).UseSystemConfigSpanForQueues = true
})
t.Run(`kafka`, kafkaTest(testFn, useSysCfgInKV))
}

func TestChangefeedHandlesDrainingNodes(t *testing.T) {
Expand Down

0 comments on commit e96c8bf

Please sign in to comment.