-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse CycloneDX Legal information #1985
Conversation
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Did you get small-legal-cyclonedx.json from somewhere? It seems to be not correct according to the spec.
|
oh yeah its not real. I made it up to capture multiple usecases |
internal/testing/testdata/exampledata/small-legal-cyclonedx.json
Outdated
Show resolved
Hide resolved
internal/testing/testdata/exampledata/small-legal-cyclonedx.json
Outdated
Show resolved
Hide resolved
internal/testing/testdata/exampledata/small-legal-cyclonedx.json
Outdated
Show resolved
Hide resolved
internal/testing/testdata/exampledata/small-legal-cyclonedx.json
Outdated
Show resolved
Hide resolved
…DX and fix unit tests Signed-off-by: pxp928 <parth.psu@gmail.com>
@jeffmendoza PTAL, I made the changes based on the comments and updated the unit tests. |
Description of the PR
Update CDX parser to capture legal information that is contained in the SBOM. Unit tests have been updated to test the new functionality.
Related to the open issue: #1014, and completes the update to the CycloneDX Parser.
Updates were made based on the design doc: https://docs.google.com/document/d/1NmLlU5wuP2X9CK7QCWZkkOciNn1QFLKQCFCW9CEI8HQ/edit
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run