Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the e2e #2010

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix the e2e #2010

merged 1 commit into from
Jul 9, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

- The e2e is failing here: https://github.com/guacsec/guac/actions/runs/9859126595/job/27222088392, and this should fix the error
- This issue is being caused because of a race condition.

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@pxp928 pxp928 requested a review from mihaimaruseac July 9, 2024 18:24
@kodiakhq kodiakhq bot merged commit 82e3f80 into guacsec:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants