Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guard compat #26

Merged
merged 7 commits into from
Dec 6, 2014
Merged

Use guard compat #26

merged 7 commits into from
Dec 6, 2014

Conversation

e2
Copy link
Contributor

@e2 e2 commented Dec 6, 2014

  • update to RSpec 3
  • use guard-compat

This conversion is done by Transpec 2.3.8 with the following command:
    transpec

* 17 conversions
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 8 conversions
    from: obj.should
      to: expect(obj).to

* 4 conversions
    from: == expected
      to: eq(expected)

* 3 conversions
    from: be_true
      to: be_truthy

* 3 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 2 conversions
    from: obj.should_not_receive(:message)
      to: expect(obj).not_to receive(:message)

* 1 conversion
    from: be_false
      to: be_falsey

* 1 conversion
    from: obj.should_not
      to: expect(obj).not_to

For more details: https://github.com/yujinakayama/transpec#supported-conversions
@e2
Copy link
Contributor Author

e2 commented Dec 6, 2014

@rymai - could you add me to rubygems/gems/guard-bundler so I can release this? (doesn't affect users, but it does affect tests of other guard plugins which use this).

P.S. should I remove you from being notified about Travis builds in other gems (if I remember)?

e2 added a commit that referenced this pull request Dec 6, 2014
@e2 e2 merged commit d7ecbcb into master Dec 6, 2014
@e2 e2 deleted the use_guard_compat branch December 6, 2014 16:40
@rymai
Copy link
Member

rymai commented Dec 8, 2014

@e2 Done, thanks! https://rubygems.org/gems/guard-bundler

Yes you can remove me from the recipients list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants