Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax bundler dependency to >= 1.3.0 #35

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Conversation

rymai
Copy link
Member

@rymai rymai commented Jan 10, 2019

Closes #34.

Signed-off-by: Rémy Coutable <remy@rymai.me>
@rymai rymai merged commit d43018f into master Jan 10, 2019
@rymai rymai deleted the 34-relax-bundler-dependency branch January 10, 2019 14:04
@AlexWayfer
Copy link

Please, don't relax this way. You may not what changes the 3 version will include. For example: rubygems/bundler#694

I recommend to use something like '>= 1.3.0', '< 3'

@rymai
Copy link
Member Author

rymai commented Jan 16, 2019

Please, don't relax this way. You may not what changes the 3 version will include. For example: bundler/bundler#694

I recommend to use something like '>= 1.3.0', '< 3'

You're right, I mimicked what Rails does but it's not the same use case here.

@rymai
Copy link
Member Author

rymai commented Jan 16, 2019

@AlexWayfer FYI guard-bundler 2.2.1 has been released with this bundler restriction.

@AlexWayfer
Copy link

@AlexWayfer FYI guard-bundler 2.2.1 has been released with this bundler restriction.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants