fix requires and crashes

guard · Dec 17, 2014 · d50377c · d50377c
1 parent 2687809
commit d50377c
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 4 deletions.
diff --git a/lib/guard/cucumber/focuser.rb b/lib/guard/cucumber/focuser.rb
@@ -1,3 +1,5 @@
+require "guard/compat/plugin"
+
 module Guard
   class Cucumber < Plugin
     # The Cucumber focuser updates cucumber feature paths to

diff --git a/lib/guard/cucumber/inspector.rb b/lib/guard/cucumber/inspector.rb
@@ -1,3 +1,5 @@
+require "guard/compat/plugin"
+
 module Guard
   class Cucumber < Plugin
     # The inspector verifies of the changed paths are valid

diff --git a/lib/guard/cucumber/notification_formatter.rb b/lib/guard/cucumber/notification_formatter.rb
@@ -1,3 +1,10 @@
+# Conditionally require this because it's run outside Guard
+# TODO: MOVE THIS OUTSIDE THE FORMATTER!!!!
+require "guard/notifier"
+
+require "cucumber"
+require "guard/compat/plugin"
+
 require "cucumber/formatter/console"
 require "cucumber/formatter/io"
 
@@ -69,7 +76,7 @@ def after_feature_element(feature_element)
       def step_name(_keyword, step_match, status, _src_indent, _bckgnd, _loc)
         return unless [:failed, :pending, :undefined].index(status)
 
-        #TODO: "NO COVERATE HERE!!"
+        # TODO: NO COVERAGE HERE!
         @rerun = true
         step_name = step_match.format_args(lambda { |param| "*#{ param }*" })
 
@@ -83,6 +90,7 @@ def step_name(_keyword, step_match, status, _src_indent, _bckgnd, _loc)
       # result of the feature tests.
       #
       def notify_summary
+        # TODO: MOVE THIS OUTSIDE THE FORMATTER!!!!
         statuses = [:failed, :skipped, :undefined, :pending, :passed]
         statuses = statuses.reverse
         statuses.select! { |status| step_mother.steps(status).any? }

diff --git a/lib/guard/cucumber/runner.rb b/lib/guard/cucumber/runner.rb
@@ -1,3 +1,7 @@
+require "guard/compat/plugin"
+
+require "guard/cucumber/focuser"
+
 module Guard
   class Cucumber < Plugin
     # The Cucumber runner handles the execution of the cucumber binary.

diff --git a/spec/guard/cucumber/focuser_spec.rb b/spec/guard/cucumber/focuser_spec.rb
@@ -1,3 +1,5 @@
+require "guard/compat/test/helper"
+
 require "guard/cucumber/focuser"
 
 RSpec.describe Guard::Cucumber::Focuser do

diff --git a/spec/guard/cucumber_spec.rb b/spec/guard/cucumber_spec.rb
@@ -1,3 +1,6 @@
+require "guard/compat/test/helper"
+require "guard/cucumber"
+
 RSpec.describe Guard::Cucumber do
   subject { Guard::Cucumber.new(options) }
 

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,6 +1,3 @@
-require "guard/compat/test/helper"
-require "guard/cucumber"
-
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # The generated `.rspec` file contains `--require spec_helper` which will cause