Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber task fails in notification routine #22

Closed
astery opened this issue Mar 8, 2015 · 3 comments
Closed

Cucumber task fails in notification routine #22

astery opened this issue Mar 8, 2015 · 3 comments

Comments

@astery
Copy link

astery commented Mar 8, 2015

To reproduce:

git clone https://github.com/astery/video-vault.git
cd video-vault
git checkout b04ffd9
ln -s database.yml.example config/database.yml
sed -i -r 's/, :notification => false//' Guardfile # Enable notifications
bundle install
bundle exec guard

I have a following error output.

Arguments of self.notify(msg, options = {}) in /home/user/.gem/ruby/2.0.0/gems/guard-compat-1.2.1/lib/guard/compat/plugin.rb:

["a regular user \"*Jack*\"", {:title=>nil, :image=>:pending}]

a regular user "Jack" is background section step.

@astery
Copy link
Author

astery commented Mar 8, 2015

This, situation can be fixed with adding before_background hook in notification_formatter.rb:

def before_background(el)
  @feature_name = el.name
end

But I don't sure if it's the best one.

@e2 e2 closed this as completed in 4053399 Mar 8, 2015
e2 added a commit that referenced this issue Mar 8, 2015
handle background scenario failures [fix #22]
@e2
Copy link

e2 commented Mar 8, 2015

Thank you very much for such a detailed report (I really appreciate it!) - and for the repo (I would've never guessed it was because of a failing background scenario).

I've released 1.5.4 - let me know if you have any other issues.

@astery
Copy link
Author

astery commented Mar 8, 2015

Thank you too for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants