Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize command line args #30

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Standardize command line args #30

merged 1 commit into from
Nov 10, 2015

Conversation

hron
Copy link

@hron hron commented Nov 10, 2015

Current scheme of command line args in guard-cucumber is very
sophisticated. However it doesn't allow to use tools like
parallel_tests.

This change standardize command line args with guard-rspec gem. The
implemented change deprecates a lot of options, but it allows to use all
of them by utilizing :cmd option.

Current scheme of command line args in guard-cucumber is very
sophisticated. However it doesn't allow to use tools like
parallel_tests.

This change standardize command line args with guard-rspec gem. The
implemented change deprecates a lot of options, but it allows to use all
of them by utilizing `:cmd` option.
e2 added a commit that referenced this pull request Nov 10, 2015
Standardize command line args
@e2 e2 merged commit e64ca5c into guard:master Nov 10, 2015
@e2
Copy link

e2 commented Nov 10, 2015

Really cool patch and cleanup, thanks! I like how you're using Guard::RSpec as a reference. (Both these plugins have a lot in common).

Also, recent parallel_tests has a -- option, which kind of helps manage RSpec and Parallel test options:

https://github.com/grosser/parallel_tests#setup-for-non-rails

I'll release this as 2.0.0 . I don't think a deprecation version is needed, since migrating should be trivial.

@e2
Copy link

e2 commented Nov 10, 2015

Released as v2.0.0.

Thanks again!

@sentience
Copy link

Migration may be trivial, but it should still be documented. Any plans to update the changelog for 2.0? I could try contributing something, but I’d have to read the code change to work out what the correct approach for migrating might be.

@e2
Copy link

e2 commented Dec 16, 2015

@sentience - yes, sorry, I've been using GitHub releases instead of the changelog, but I didn't link it.

See here: https://github.com/guard/guard-cucumber/releases

@sentience
Copy link

@e2 Am I missing something? That release note doesn’t document the migration process either. As far as I can see, it just links to the code change, which is pretty tough to parse.

@e2
Copy link

e2 commented Dec 16, 2015

@sentience - yes, I guess the Readme could have a small migration section. The change is mostly cleanup and renaming options.

Personally, I'd just show an error when there are unrecognized options (some other plugins probably do that already).

The basic change is going from :cli, :cmd_prefix, :bundler, :binstubs and to just :cmd and :cmd_additional_args (less options, clearer, easier to setup more complex scenarios).

If you submit a PR for this, I'll gladly accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants