Feature: Cucumber 3.x Support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The dump_count method was previously found in Cucumber::Formatter::Summary and Cucumber::Formatter::Html - This method was extracted from <cucumber/cucumber-ruby@4154c8ca> - Closes guard#36 <guard#36>
- Prevent dependencies on outdated gems. - Cucumber 3.1 is now a minimum version, not a fixed dependency.
todd-a-jacobs
changed the title
|
This seems like the best minimal upgrade path to unblock folk without investigating what's needed to use |
|
Thanks for this, @todd-a-jacobs. |
|
Hi, are this gem still maintained ? |
|
Will this be merged at some point? |
|
Can I help get this merged? |
|
This still should be merged. Again, I'll ask: what's the delay? Can I help somehow? |
|
@todd-a-jacobs Thank you, looks good to me! It looks like @e2 isn't maintaining the gem anymore so I'll merge and release a new version. ☀️ 🚀 |
This was referenced Apr 7, 2020
|
@rymai Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimalist pull-request that:
This appears to close #36 and stops the NoMethodError exception raised from Guard::Cucumber::NotificationFormatter.