-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requested additions for :server_mount option #138
Changes from 3 commits
6d47244
c2df160
7581f67
d0da317
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,11 @@ class CLI < Thor | |
aliases: '-u', | ||
desc: 'The url of the Jasmine test runner' | ||
|
||
method_option :mount, | ||
type: :string, | ||
aliases: '-m', | ||
desc: 'The mount point of the Jasmine test runner' | ||
|
||
method_option :timeout, | ||
type: :numeric, | ||
aliases: '-t', | ||
|
@@ -148,6 +153,7 @@ def spec(*paths) | |
runner_options[:spec_dir] = options.spec_dir || (File.exists?(File.join('spec', 'javascripts')) ? File.join('spec', 'javascripts') : 'spec') | ||
runner_options[:server] = options.server.to_sym == :auto ? ::Guard::Jasmine::Server.detect_server(runner_options[:spec_dir]) : options.server.to_sym | ||
runner_options[:jasmine_url] = options.url || "http://localhost:#{ runner_options[:port] }#{ options.server.to_sym == :jasmine_gem ? '/' : '/jasmine' }" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Won't this line also need to interpolate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good point... I had intentionally not added that in, figuring that to leave the default mount point to be /jasmine in the interest of minimum disruption, but it would be more internally consistent. Anyone with add'l thoughts on the matter? |
||
runner_options[:server_mount] = options.mount || '/jasmine' | ||
runner_options[:phantomjs_bin] = options.bin || CLI.which('phantomjs') | ||
runner_options[:timeout] = options.timeout | ||
runner_options[:verbose] = options.verbose | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos