Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detect a directory as the phantomjs executable #165

Merged
merged 1 commit into from
Apr 2, 2014
Merged

Fix detect a directory as the phantomjs executable #165

merged 1 commit into from
Apr 2, 2014

Commits on Apr 2, 2014

  1. Fix detect a directory as the phantomjs executable 

    `File.executable?(exe)` will return `true` for directories. This patch ensures that only files are selected.

With the existing code, it can detect a directory named `phantomjs` as the phantomjs executable. This was exactly what was happening in my case: Sencha Cmd tool creates a "phantomjs" directory which is reachable from the path, and this was making guard-jasmine fail.
    @jorgemanrubia
    jorgemanrubia committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    76d1a5b View commit details
    Browse the repository at this point in the history