Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version parser for phantomjs 1.5 (development) #26

Merged
merged 1 commit into from
Jan 11, 2012
Merged

Fix version parser for phantomjs 1.5 (development) #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/guard/jasmine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ def jasmine_runner_available?(url)
def phantomjs_bin_valid?(bin)
if bin && !bin.empty?
version = `#{ bin } --version`
# remove all but version from "1.5 (development)"
version = version.match(/(\d\.\d)/)[0]

if !version
notify_failure('PhantomJS executable missing', "PhantomJS executable doesn't exist at #{ bin }")
Expand Down