Fix crash handling a request for a directory #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,13 +10,13 @@ class WebSocket < EventMachine::WebSocket::Connection | |||
| def dispatch(data) | |||
| parser = Http::Parser.new | |||
| parser << data | |||
| request_path = URI.parse(parser.request_url).path | |||
| request_path = '.' + URI.parse(parser.request_url).path # prepend with '.' to make it usable as a file path | |||
There was a problem hiding this comment.
Should I fix this? (other lines in the file have the same length - so I don't know if this is preferred)
There was a problem hiding this comment.
Could you add the comment on a new line before? Thanks!
|
I fixed the comment and (hopefully, still rather new to this) squashed it in the commit |
|
+:1+ |
thibaudgg
added a commit
that referenced
this pull request
May 21, 2014
Fix crash handling a request for a directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a request for an existing directory, the tool tries to serve this as a file which results in an exception: ...
in 'send_file_data': : 1 Is a directory (IOError)The pull request adds a check for this.