Optionally push system notifications when reloading #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| UI.info "Reloading browser: #{paths.join(' ')}" | ||
| msg = "Reloading browser: #{paths.join(' ')}" | ||
| UI.info msg | ||
| Notifier.notify(msg, title: 'Reloading browser', image: :success) if options[:notify] |
|
@thibaudgg "by default doesn't send notification" spec doesn't seem valuable for me, but since you're measuring code coverage I decided to keep it. |
Closed
|
|
||
| describe "#reload_browser(paths = [])" do | ||
| it "displays a message" do | ||
| expect(Guard::UI).to receive(:info).with("Reloading browser: stylesheets/layout.css stylesheets/style.css") | ||
| expect(Guard::UI).to receive(:info).with('Reloading browser: stylesheets/layout.css stylesheets/style.css') |
| end | ||
|
|
||
| it "optionally pushes notification" do | ||
| expect(::Guard::Notifier).to receive(:notify).with(kind_of(String), have_key(:title)) |
|
Looks good, please just fix the two houndci issue and it'll be merge-able. Thanks! |
|
|
||
| it "optionally pushes notification" do | ||
| expect(::Guard::Notifier).to receive(:notify) | ||
| .with(kind_of(String), have_key(:title)) |
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
|
|
||
| it "optionally pushes notification" do | ||
| expect(::Guard::Notifier).to receive(:notify) | ||
| .with(kind_of(String), have_key(:title)) |
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
|
@thibaudgg Hound looks happy now, although I personally don't agree 'don\t' do something' is better than "don't do something" |
|
What about 'does not' ? |
|
|
|
👌 |
thibaudgg
added a commit
that referenced
this pull request
Jun 25, 2014
Optionally push system notifications when reloading
|
2.3.0 released, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.