Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Guard::Compat and update to RSpec 3.1 #124

Merged
merged 8 commits into from
Dec 9, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .hound.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
ruby:
enabled: true
config_file: .rubocop_merged_for_hound.yml

coffee_script:
enabled: true
265 changes: 265 additions & 0 deletions .hound/defaults.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,265 @@
#
# NOTE: * DO NOT EDIT THIS FILE! *
#
# This file should match the config/style_guides/ruby.yml from the
# thoughtbot/hound project

AllCops:
Exclude:
- db/schema.rb

AccessorMethodName:
Enabled: false

ActionFilter:
Enabled: false

Alias:
Enabled: false

ArrayJoin:
Enabled: false

AsciiComments:
Enabled: false

AsciiIdentifiers:
Enabled: false

Attr:
Enabled: false

BlockNesting:
Enabled: false

CaseEquality:
Enabled: false

CharacterLiteral:
Enabled: false

ClassAndModuleChildren:
Enabled: false

ClassLength:
Enabled: false

ClassVars:
Enabled: false

CollectionMethods:
PreferredMethods:
find: detect
reduce: inject
collect: map
find_all: select

ColonMethodCall:
Enabled: false

CommentAnnotation:
Enabled: false

CyclomaticComplexity:
Enabled: false

Delegate:
Enabled: false

DeprecatedHashMethods:
Enabled: false

Documentation:
Enabled: false

DotPosition:
EnforcedStyle: trailing

DoubleNegation:
Enabled: false

EachWithObject:
Enabled: false

EmptyLiteral:
Enabled: false

Encoding:
Enabled: false

EvenOdd:
Enabled: false

FileName:
Enabled: false

FlipFlop:
Enabled: false

FormatString:
Enabled: false

GlobalVars:
Enabled: false

GuardClause:
Enabled: false

IfUnlessModifier:
Enabled: false

IfWithSemicolon:
Enabled: false

InlineComment:
Enabled: false

Lambda:
Enabled: false

LambdaCall:
Enabled: false

LineEndConcatenation:
Enabled: false

LineLength:
Max: 80

MethodLength:
Enabled: false

ModuleFunction:
Enabled: false

NegatedIf:
Enabled: false

NegatedWhile:
Enabled: false

Next:
Enabled: false

NilComparison:
Enabled: false

Not:
Enabled: false

NumericLiterals:
Enabled: false

OneLineConditional:
Enabled: false

OpMethod:
Enabled: false

ParameterLists:
Enabled: false

PercentLiteralDelimiters:
Enabled: false

PerlBackrefs:
Enabled: false

PredicateName:
NamePrefixBlacklist:
- is_

Proc:
Enabled: false

RaiseArgs:
Enabled: false

RegexpLiteral:
Enabled: false

SelfAssignment:
Enabled: false

SingleLineBlockParams:
Enabled: false

SingleLineMethods:
Enabled: false

SignalException:
Enabled: false

SpecialGlobalVars:
Enabled: false

StringLiterals:
EnforcedStyle: double_quotes

VariableInterpolation:
Enabled: false

TrailingComma:
Enabled: false

TrivialAccessors:
Enabled: false

VariableInterpolation:
Enabled: false

WhenThen:
Enabled: false

WhileUntilModifier:
Enabled: false

WordArray:
Enabled: false

# Lint

AmbiguousOperator:
Enabled: false

AmbiguousRegexpLiteral:
Enabled: false

AssignmentInCondition:
Enabled: false

ConditionPosition:
Enabled: false

DeprecatedClassMethods:
Enabled: false

ElseLayout:
Enabled: false

HandleExceptions:
Enabled: false

InvalidCharacterLiteral:
Enabled: false

LiteralInCondition:
Enabled: false

LiteralInInterpolation:
Enabled: false

Loop:
Enabled: false

ParenthesesAsGroupedExpression:
Enabled: false

RequireParentheses:
Enabled: false

UnderscorePrefixedVariableName:
Enabled: false

Void:
Enabled: false
19 changes: 19 additions & 0 deletions .hound/overrides.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# NOTE: DO NOT put a 'inheried_from' in this file, because Hound with silently
# ignore it
#
# Files you want to exclude
AllCops:
# Rails cops (so we don't need to run with -R option)
RunRailsCops: true
Exclude:
- db/schema.rb
- Gemfile
- Rakefile

# TODO: put your overrides here:

StringLiterals:
EnforcedStyle: single_quotes
#
# LineLength:
# Max: 200
2 changes: 2 additions & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
--color
--require spec_helper
8 changes: 8 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
inherit_from:
- .hound/defaults.yml
- .hound/overrides.yml
- .rubocop_todo.yml

# Rails cops (so we don't need to run with -R option)
AllCops:
RunRailsCops: true
41 changes: 41 additions & 0 deletions .rubocop_merged_for_hound.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# This is a file generated by `hound-tools`
#
# We don't include .hound/defaults.yml, because Hound has internally
# loaded them at this point
#
# ---------------------------------
# .hound/overrides.yml
# ---------------------------------
# NOTE: DO NOT put a 'inheried_from' in this file, because Hound with silently
# ignore it
#
# Files you want to exclude
AllCops:
# Rails cops (so we don't need to run with -R option)
RunRailsCops: true
Exclude:
- db/schema.rb
- Gemfile
- Rakefile

# TODO: put your overrides here:

StringLiterals:
EnforcedStyle: single_quotes
#
# LineLength:
# Max: 200
# ---------------------------------
# .rubocop_todo.yml
# ---------------------------------
# This configuration was generated by `rubocop --auto-gen-config`
# on 2014-12-09 05:16:56 +0100 using RuboCop version 0.25.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 12
# Configuration parameters: AllowURI.
Metrics/LineLength:
Max: 163
11 changes: 11 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This configuration was generated by `rubocop --auto-gen-config`
# on 2014-12-09 05:16:56 +0100 using RuboCop version 0.25.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 12
# Configuration parameters: AllowURI.
Metrics/LineLength:
Max: 163
9 changes: 6 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@ source "https://rubygems.org"
gemspec

group :development do
gem 'ruby_gntp'
gem 'guard-rspec'
gem "ruby_gntp", require: false
gem "guard-rspec", require: false
gem "hound-tools", '~> 0.0.4', require: false
end

group :test do
gem 'coveralls', require: false
gem "coveralls", require: false
gem "rake", require: false
gem 'rspec', '~> 3.1'
end
16 changes: 12 additions & 4 deletions Guardfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
guard :rspec do
watch(%r{spec/.+_spec.rb})
watch(%r{lib/(.+)\.rb}) { |m| "spec/lib/#{m[1]}_spec.rb" }
watch('spec/spec_helper.rb') { "spec" }
group :specs, halt_on_fail: true do
guard :rspec, cmd: 'bundle exec rspec', failed_mode: :keep do
watch(%r{spec/.+_spec.rb})
watch(%r{lib/(.+)\.rb}) { |m| "spec/lib/#{m[1]}_spec.rb" }
watch('spec/spec_helper.rb') { 'spec' }
end

guard :rubocop, all_on_start: false, cli: '--rails' do
watch(%r{.+\.rb$}) { |m| m[0] }
watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
watch(%r{(?:.+/)?\.rubocop_todo\.yml$}) { |m| File.dirname(m[0]) }
end
end
Loading