Prevent requesting arbitrary file paths via socket #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain situations, specially crafted HTTP GET requests on the livereload socket (default: 35729) may cause any user readable file to be sent over that socket. Temporarily in this patch, requests for readable files now result in 403 HTTP error responses. The exception is of course the file './livereload.js'. Security vulnerability example: Accessing the socket on localhost:35729 and requesting: ./../../etc/passwd (note the single leading dot) to be expanded to "../../../etc/passwd", which may effectively serve the contents of /etc/passwd.
| @@ -6,6 +6,9 @@ | |||
| module Guard | |||
| class LiveReload | |||
| class WebSocket < EventMachine::WebSocket::Connection | |||
| HTTP_DATA_FORBIDDEN = "HTTP/1.1 403 Forbidden\r\nContent-Type: text/plain\r\nContent-Length: 13\r\n\r\n403 Forbidden" | |||
| HTTP_DATA_NOT_FOUND = "HTTP/1.1 404 Not Found\r\nContent-Type: text/plain\r\nContent-Length: 13\r\n\r\n404 Not Found" | |||
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
e2
added a commit
that referenced
this pull request
Feb 4, 2016
Prevent requesting arbitrary file paths via socket
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, specially crafted HTTP GET requests on the
livereload socket (default: 35729) may cause any user readable file to
be sent over that socket.
Temporarily in this patch, requests for readable files now result in 403
HTTP error responses. The exception is of course the file
'./livereload.js'.
Security vulnerability example:
Accessing the socket on localhost:35729 and requesting:
./../../etc/passwd (note the single leading dot)
to be expanded to "../../../etc/passwd", which may effectively serve the
contents of /etc/passwd.