remove dependency on Http::Parser#request_path #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
thibaudgg
added a commit
that referenced
this pull request
Jan 16, 2014
remove dependency on Http::Parser#request_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream releases of the c http_parser no longer expose the request_path method, causing Websocket#dispatch to crash out.
lib/guard/livereload/websocket.rb:15:in 'dispatch': undefined method 'request_path' for #<HTTP::Parser:0x007ff21378e670> (NoMethodError)Also see: tmm1/http_parser.rb#8
I'm not sure exactly what combination of versions of gems pulls in a recent enough version to cause this to be a problem, as I have a lot of complicated dependencies around em-http-request etc.
Anyway, we don't need to depend on request_path, its trivial to use URI.parse().path to remove this dependency, and make guard-livereload a bit more future proof.