Support rspec-2 and rspec-3 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dchelimsky, thanks for your PR (and RSpec!). Yes a guard for the focus tag would be much appreciate! |
… for rspec < 3 This should be removed eventually - definitely before rspec-4 is out (2020?).
|
@thibaudgg done - would you prefer this all get squashed into one commit? |
|
No, that's nice like that. Thanks! |
|
Thx! |
|
4.2.0 released! |
|
Wow, that was fast! Double thanks! |
|
You may also want to update the README. It says: ...which implies it's not compatible with RSpec 3. |
|
Yep, good point. Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates guard-rspec to work with rspec >= 2.14, < 4
This allows guard-rspec users to choose when to upgrade to rspec-3 without having to also update guard-rspec at the same time (assuming they've at least upgraded to a version of guard-rspec that includes this PR).
It is also mostly compatible with guard-rspec developers being able to choose rspec-2.x or rspec-3.x. The only thing missing is that if you are using rspec-2.x and want to use
:focusor:focused, it won't work without:focus => true. If you prefer, I can add a guard for that functionality e.g.