Fix dependencies #236

yujinakayama · 2013-12-27T03:39:52Z

Problem

With the current rspec dependency definition in guard-rspec:

s.add_dependency 'rspec', '>= 2.14', '~> 3.0.0.beta', '< 4.0'

And a Gemfile in another project:

gem 'rspec', '~> 2.14'
gem 'guard-rspec', '~> 4.2.2'

Then run Bundler:

$ bundle update
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Bundler could not find compatible versions for gem "rspec":
  In Gemfile:
    rspec (~> 2.14) ruby

    guard-rspec (~> 4.2.2) ruby depends on
      rspec (3.0.0.beta1)

This means the ~> 3.0.0.beta negates the >= 2.14.

Solution

If guard-rspec defines:

s.add_dependency 'rspec', '>= 2.14', '< 4.0'

Then this works in another project:

gem 'rspec', '~> 2.14'
gem 'guard-rspec', '~> 4.2.2'

And this also works:

gem 'rspec', '~> 3.0.0.beta1'
gem 'guard-rspec', '~> 4.2.2'

I've tested these behavior with my gem.

This fixes #235.

Problem ======= With the current rspec dependency definition in guard-rspec: s.add_dependency 'rspec', '>= 2.14', '~> 3.0.0.beta', '< 4.0' And a Gemfile in another project: gem 'rspec', '~> 2.14' gem 'guard-rspec', '~> 4.2.2' Then run Bundler: $ bundle update Fetching gem metadata from https://rubygems.org/......... Fetching additional metadata from https://rubygems.org/.. Resolving dependencies... Bundler could not find compatible versions for gem "rspec": In Gemfile: rspec (~> 2.14) ruby guard-rspec (~> 4.2.2) ruby depends on rspec (3.0.0.beta1) This means the '~> 3.0.0.beta' negates the '>= 2.14'. Solution ======== If guard-rspec defines: s.add_dependency 'rspec', '>= 2.14', '< 4.0' This works in another project: gem 'rspec', '~> 2.14' gem 'guard-rspec', '~> 4.2.2' And this also works: gem 'rspec', '~> 3.0.0.beta1' gem 'guard-rspec', '~> 4.2.2'

'~> 2.1' is equivalent of '>= 2.1', '< 3.0'.

coveralls · 2013-12-27T03:41:18Z

Coverage remained the same when pulling 6e7fa79 on yujinakayama:fix-deps into 394596b on guard:master.

coveralls · 2013-12-27T03:42:48Z

Coverage remained the same when pulling 6e7fa79 on yujinakayama:fix-deps into 394596b on guard:master.

thibaudgg · 2013-12-27T09:06:43Z

Makes sense to me, but that was added because of #232

@jgorset @yujinakayama which version of ruby/rubygem/bundler are you using?

yujinakayama · 2013-12-27T09:13:10Z

$ ruby -v
ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-darwin13.0.0]
$ gem -v
2.0.14
$ bundle version
Bundler version 1.5.0

yujinakayama · 2013-12-27T10:02:55Z

The version specifiers in the dependency specification must be all satisfied. So I think including ~> 3.0.0.beta is not what we want since we still need to support rspec 2.14.
https://github.com/rubygems/rubygems/blob/v2.2.0/lib/rubygems/requirement.rb#L228

def test_satisfaction(requirement, label)
  puts label

  [
    '2.13.0',
    '2.14.0',
    '2.99.0.beta1',
    '2.99.0',
    '3.0.0.beta1',
    '3.0.0',
    '4.0.0'
  ].each do |version|
    satisfy = requirement.satisfied_by?(Gem::Version.new(version))
    puts "  #{version.ljust(12)} #{satisfy}"
  end

  puts
end

requirement_with_beta = Gem::Requirement.new('>= 2.14', '~> 3.0.0.beta', '< 4.0')
requirement_without_beta = Gem::Requirement.new('>= 2.14', '< 4.0')

test_satisfaction(requirement_with_beta, "With '~> 3.0.0.beta'")
test_satisfaction(requirement_without_beta, "Without '~> 3.0.0.beta'")

$ ruby test_requirement.rb
With '~> 3.0.0.beta'
  2.13.0       false
  2.14.0       false
  2.99.0.beta1 false
  2.99.0       false
  3.0.0.beta1  true
  3.0.0        true
  4.0.0        false

Without '~> 3.0.0.beta'
  2.13.0       false
  2.14.0       true
  2.99.0.beta1 true
  2.99.0       true
  3.0.0.beta1  true
  3.0.0        true
  4.0.0        false

I think that “Prereleases need to be opt-in explicitly” is only for installation. It's not related to whether a prerelease version satisfies requirements when resolving dependencies.

jgorset · 2013-12-27T11:30:50Z

$ ruby -v
ruby 2.0.0p195 (2013-05-14 revision 40734) [x86_64-darwin12.3.0]
$ gem -v
2.1.11
$ bundle -v
Bundler version 1.3.5

It seems I am using an older version of bundler and a newer version of rubygems, yet my result of test_requirements.rb is identical to that of @yujinakayama.

jgorset · 2013-12-27T11:32:15Z

Can you try running my proof of concept against your fork rather than mine and post your results, @yujinakayama?

yujinakayama · 2013-12-27T11:39:30Z

@jgorset I can but the situation is different from your trial because guard-rspec 4.2.2 is already released.

yujinakayama · 2013-12-27T11:50:00Z

I think I've found the cause. Specifying rspec and specifying rspec-rails lead to different results.

With rpec-rails:

$ cat Gemfile
source 'https://rubygems.org'

gem 'rspec-rails', '~> 3.0.0.beta1'
gem 'guard-rspec', '4.2.0'
$ bundle install --path vendor/bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Bundler could not find compatible versions for gem "rspec-mocks":
  In Gemfile:
    guard-rspec (= 4.2.0) ruby depends on
      rspec-mocks (~> 2.14.0) ruby

    rspec-rails (~> 3.0.0.beta1) ruby depends on
      rspec-mocks (3.0.0.beta1)

With rspec:

$ cat Gemfile
source 'https://rubygems.org'

gem 'rspec', '~> 3.0.0.beta1'
gem 'guard-rspec', '4.2.0'
$ bundle install --path vendor/bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Installing rb-fsevent (0.9.3)
Installing lumberjack (1.0.4)
Installing timers (1.1.0)
Installing diff-lcs (1.2.5)
Installing formatador (0.2.4)
Installing coderay (1.1.0)
Installing method_source (0.8.2)
Using bundler (1.5.0)
Installing slop (3.4.7)
Installing rspec-support (3.0.0.beta1)
Installing thor (0.18.1)
Installing celluloid (0.15.2)
Installing rspec-mocks (3.0.0.beta1)
Installing rspec-core (3.0.0.beta1)
Installing rspec-expectations (3.0.0.beta1)
Installing pry (0.9.12.4)
Installing rspec (3.0.0.beta1)
Installing ffi (1.9.3)
Installing rb-inotify (0.9.3)
Installing listen (2.4.0)
Installing guard (2.2.5)
Installing guard-rspec (4.2.0)
Your bundle is complete!
It was installed into ./vendor/bundle

yujinakayama · 2013-12-27T12:02:35Z

Anyway, I think rspec 2.14 support should get preference over 3.0 beta support.

@jgorset By the way, I found a workaround for your situation:

$ cat Gemfile 
source 'https://rubygems.org'

gem 'rspec',       '~> 3.0.0.beta1' # Specify both `rspec` and `rspec-rails`
gem 'rspec-rails', '~> 3.0.0.beta1'
gem 'guard-rspec', '4.2.0'
$ bundle install --path vendor/bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Using minitest (4.7.5)
Installing multi_json (1.8.2)
Installing i18n (0.6.9)
Installing atomic (1.1.14)
...

Could you try this?

thibaudgg · 2013-12-27T12:37:27Z

if @yujinakayama workaround works, I'm to set the preference on 2.14 too.

thibaudgg · 2013-12-28T15:04:48Z

@jgorset do you confirm that @yujinakayama workaround is working well? Thanks!

thibaudgg · 2013-12-30T12:32:12Z

Ok I confirm that adding gem 'rspec', '~> 3.0.0.beta1' fix the beta release issue with rspec-rails.
Thanks @yujinakayama for you PR!

Fix dependencies

thibaudgg · 2013-12-30T12:36:46Z

4.2.3 released, happy new year!

guard/guard-rspec#236

yujinakayama · 2013-12-30T16:03:47Z

Thanks!

jgorset · 2014-01-02T09:18:42Z

Sorry for the late reply (and likewise the inconvenience in the first place), @thibaudgg and @yujinakayama!

yujinakayama added 2 commits December 27, 2013 12:34

Improve other dependencies

6e7fa79

'~> 2.1' is equivalent of '>= 2.1', '< 3.0'.

thibaudgg added a commit that referenced this pull request Dec 30, 2013

Merge pull request #236 from yujinakayama/fix-deps

fd89cd5

Fix dependencies

thibaudgg merged commit fd89cd5 into guard:master Dec 30, 2013

yujinakayama deleted the fix-deps branch December 30, 2013 12:34

yujinakayama added a commit to yujinakayama/transpec that referenced this pull request Dec 30, 2013

Use guard-rspec 4.2.3 or later

43bb4aa

guard/guard-rspec#236

yujinakayama added a commit to rubocop/guard-rubocop that referenced this pull request Dec 30, 2013

Use guard-rspec 4.2.3 or later

1c78567

guard/guard-rspec#236

This was referenced Feb 19, 2014

Incompatibilities with rspec-core edge and version issues #249

Closed

undefined method 'parse_options' #251

Closed

myronmarston mentioned this pull request Mar 24, 2014

RSpec 3 compatibility alexrothenberg/ammeter#24

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dependencies #236

Fix dependencies #236

yujinakayama commented Dec 27, 2013

coveralls commented Dec 27, 2013

coveralls commented Dec 27, 2013

thibaudgg commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

jgorset commented Dec 27, 2013

jgorset commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

thibaudgg commented Dec 27, 2013

thibaudgg commented Dec 28, 2013

thibaudgg commented Dec 30, 2013

thibaudgg commented Dec 30, 2013

yujinakayama commented Dec 30, 2013

jgorset commented Jan 2, 2014

Fix dependencies #236

Fix dependencies #236

Conversation

yujinakayama commented Dec 27, 2013

Problem

Solution

coveralls commented Dec 27, 2013

coveralls commented Dec 27, 2013

thibaudgg commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

jgorset commented Dec 27, 2013

jgorset commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

yujinakayama commented Dec 27, 2013

thibaudgg commented Dec 27, 2013

thibaudgg commented Dec 28, 2013

thibaudgg commented Dec 30, 2013

thibaudgg commented Dec 30, 2013

yujinakayama commented Dec 30, 2013

jgorset commented Jan 2, 2014