#243 fix example groups #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| until spec_path?(metadata[:location]) | ||
| metadata = metadata[:example_group] | ||
| if !metadata | ||
| warn "no spec file found for #{root_metadata[:location]}" |
There was a problem hiding this comment.
You could use Guard::UI.warning there.
…e number for shared examples
| s.add_development_dependency 'pry' | ||
| s.add_development_dependency 'pry-remote' | ||
| s.add_development_dependency 'pry-stack_explorer' | ||
| s.add_development_dependency 'pry-debugger' |
There was a problem hiding this comment.
These gems seems to brake bundle install on rbx & jruby, are they really needed?
|
Pry gem's make development a little more pleasant. pry without the other gem's is a runtime dependency of guard. So I thought it would not harm, but I removed this gems. |
thibaudgg
added a commit
that referenced
this pull request
Jan 9, 2014
Fix #234 Rerun failed spec with example groups in different files does not work.
|
@slowjack2k @907th Thanks! |
|
4.2.4 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.