Fixed watchdir option #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +30,9 @@ def _parts | |||
| parts << _guard_formatter | |||
| parts << "--failure-exit-code #{FAILURE_EXIT_CODE}" | |||
| parts << options[:cmd_additional_args] || "" | |||
| parts << paths.join(' ') | |||
| paths.map do |dir, specs| | |||
| "cd #{dir} && #{parts.join(' ')} #{specs.join(' ')}" | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -22,6 +22,11 @@ def _parts | |||
| parts << _guard_formatter | |||
| parts << "--failure-exit-code #{FAILURE_EXIT_CODE}" | |||
| parts << options[:cmd_additional_args] || "" | |||
| if chdir = options[:chdir] | |||
| paths.each do |path| | |||
| path.sub!("#{chdir}#{File::SEPARATOR}", '') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think current watchdir option doesn't work as it should (please correct me if I'm missing something).
My recent project was consisted of many different modules each of them having it's own tests suite.
I've tried to use watchdir option but it didn't work as I expected.
I've created sample project and described steps to reproduce the issue and fix for the issue with my forks (https://github.com/lesniakania/guard and https://github.com/lesniakania/guard-rspec):
https://github.com/lesniakania/multiple-modules-with-guard
These changes depends on changes I've made in guard repo.