Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new accessor for example group metadata #327

Closed
wants to merge 1 commit into from
Closed

use new accessor for example group metadata #327

wants to merge 1 commit into from

Conversation

afeld
Copy link

@afeld afeld commented Jun 26, 2015

Ran into a deprecation issue when one of my specs (run via guard :rspec, cmd: 'bundle exec rspec') throws an exception:

/Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/formatters/deprecation_formatter.rb:186:in `puts': The `:example_group` key in an example group's metadata hash is deprecated. Use the example group's hash directly for the computed keys and `:parent_example_group` to access the parent example group metadata instead. Called from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:36:in `yield'. (RSpec::Core::DeprecationError)
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/formatters/deprecation_formatter.rb:125:in `print_deprecation_message'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/formatters/deprecation_formatter.rb:36:in `deprecation'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:184:in `block in notify'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:183:in `each'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:183:in `notify'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:146:in `deprecation'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/warnings.rb:11:in `deprecate'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/metadata.rb:274:in `block in backwards_compatibility_default_proc'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:36:in `yield'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:36:in `extract_spec_location'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:93:in `block in _failed_paths'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:93:in `map'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:93:in `_failed_paths'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:80:in `block in write_summary'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:87:in `open'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:87:in `_write'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:78:in `write_summary'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/guard-rspec-4.5.2/lib/guard/rspec_formatter.rb:66:in `dump_summary'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:184:in `block in notify'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:183:in `each'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:183:in `notify'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:162:in `block in finish'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:170:in `close_after'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:151:in `finish'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/reporter.rb:79:in `report'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:113:in `run_specs'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:89:in `run'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:73:in `run'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/lib/rspec/core/runner.rb:41:in `invoke'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.3.1/exe/rspec:4:in `<top (required)>'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/bin/rspec:23:in `load'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/bin/rspec:23:in `<main>'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/bin/ruby_executable_hooks:15:in `eval'
    from /Users/aidanfeldman/.rvm/gems/ruby-2.1.3/bin/ruby_executable_hooks:15:in `<main>'

More info: rspec/rspec-rails#1035.

@afeld afeld mentioned this pull request Jun 26, 2015
Merged
@e2 e2 mentioned this pull request Jun 26, 2015
Merged
@e2
Copy link
Contributor

e2 commented Jun 26, 2015

Thanks for the fix - I added specs and made it work with previous RSpec versions here: #328

@e2 e2 closed this Jun 26, 2015
e2 added a commit that referenced this pull request Jun 26, 2015
@e2
Merge pull request #328 from guard/e2-fix_example_group_deprecation
55d3bc3 
Avoid RSpec 3 deprecation warning [close #327]
@afeld
Copy link
Author

afeld commented Jun 26, 2015

Thanks for the quick turnaround!

@afeld afeld mentioned this pull request Jul 10, 2015
Open
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 98.204% when pulling caa2ee8 on 18F:example-group-deprecation into 1e71c21 on guard:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afeld @e2 @coveralls