Fix return value of the runner #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring in d4591fc broke throwing of `:task_has_failed` because the runner was changed to always return `true` from `#run` and `#run_all`. The invalid return value caused `:task_has_failed` to never be thrown, thus breaking the behavior of a group's `:halt_on_fail` option.
|
Awesome! Thanks! |
|
Released as v4.6.2 |
|
Awesome, now to update all the gems :D Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring in d4591fc broke throwing of
:task_has_failedbecause the runner was changed to always returntruefrom#runand#run_all. The invalid return value caused:task_has_failedto never be thrown, thus breaking the behavior of a group's:halt_on_failoption.