Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using Guard::UI in formatter + isolated test #374

Merged
merged 1 commit into from
May 31, 2016
Merged

stop using Guard::UI in formatter + isolated test #374

merged 1 commit into from
May 31, 2016

Conversation

e2
Copy link
Contributor

@e2 e2 commented May 31, 2016 •
edited

Formatter should be self-sufficient in that it shouldn't require
any gem or file other than what RSpec provides.

Fixes #373.

houndci-bot
houndci-bot reviewed May 31, 2016
View reviewed changes
spec/acceptance/formatter_spec.rb

Dir.mktmpdir do |path|
guard_env = {
'GUARD_RSPEC_RESULTS_FILE' => File.join(path, "results.txt")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage decreased (-78.2%) to 20.0% when pulling 567ab3e on fix-373_using_guard_ui into c4226b6 on master.

@e2 e2 force-pushed the fix-373_using_guard_ui branch 3 times, most recently from ad615d3 to 25325c1 Compare May 31, 2016 07:00
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage increased (+1.3%) to 99.507% when pulling 25325c1 on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage increased (+1.3%) to 99.507% when pulling cfa7541 on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.371% when pulling 0b30aa0 on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.369% when pulling c274d0d on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.37% when pulling 860bc1d on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.368% when pulling 9c1ed26 on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.37% when pulling 47bf9b3 on fix-373_using_guard_ui into c4226b6 on master.

@e2 e2 force-pushed the fix-373_using_guard_ui branch 2 times, most recently from 6894282 to 325e64e Compare May 31, 2016 11:00
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage increased (+1.3%) to 99.509% when pulling 325e64e on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.372% when pulling 4c5c91b on fix-373_using_guard_ui into c4226b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 99.37% when pulling 6894282 on fix-373_using_guard_ui into c4226b6 on master.

@e2 e2 force-pushed the fix-373_using_guard_ui branch from 19b67f8 to dd31709 Compare May 31, 2016 11:48
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 98.201% when pulling dd31709 on fix-373_using_guard_ui into b6ea2a4 on master.

@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage decreased (-0.04%) to 98.201% when pulling 19b67f8 on fix-373_using_guard_ui into c4226b6 on master.

@e2 e2 force-pushed the fix-373_using_guard_ui branch from dd31709 to 94eef12 Compare May 31, 2016 12:13
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 98.197% when pulling 94eef12 on fix-373_using_guard_ui into b6ea2a4 on master.

@e2 e2 force-pushed the fix-373_using_guard_ui branch from 94eef12 to 0216b0b Compare May 31, 2016 14:29
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 98.199% when pulling 0216b0b on fix-373_using_guard_ui into 40dfe60 on master.

@e2 e2 force-pushed the fix-373_using_guard_ui branch from 0216b0b to f565af6 Compare May 31, 2016 17:21
@coveralls
Copy link

coveralls commented May 31, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 98.202% when pulling f565af6 on fix-373_using_guard_ui into 40dfe60 on master.

@e2 e2 merged commit 1b69394 into master May 31, 2016
@e2 e2 deleted the fix-373_using_guard_ui branch May 31, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e2 @coveralls @houndci-bot