Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require rb-fsevent when needed, in _configure method #419

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Nov 21, 2016

This fixes an error I’ve introduced in #417, sorry for that.

The problem is: when the OS version is >= 13, then it early returns from the usable? function and does not require rb-fsevent.

      def self.usable?
        version = RbConfig::CONFIG['target_os'][OS_REGEXP, :major_version]
        return false unless version
        return true if version.to_i >= 13
        # ^--- HERE

        require 'rb-fsevent'
        ...

@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage increased (+0.5%) to 98.154% when pulling 37e9536 on jirutka:fix-rb-fsevent-2 into b653060 on guard:master.

@rymai
Copy link
Member

rymai commented Nov 23, 2016

Thanks @jirutka!

@rymai rymai self-assigned this Nov 23, 2016
@rymai rymai merged commit 1670ffe into guard:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants