Rubocop workflow with GitHub actions #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: RuboCop found unknown Ruby version 3.0 in `TargetRubyVersion` paramete...
Error: RuboCop found unknown Ruby version 3.0 in `TargetRubyVersion` parameter (in .rubocop.yml). Supported versions: 2.4, 2.5, 2.6, 2.7, 2.8
include is used at the top level. Use inside class or module.
Annotation keywords like Note should be all upper case, followed by a colon, and a space, then a note describing the problem.
Freeze mutable objects assigned to constants
Avoid comparing a variable with multiple items in a conditional, use Array#include? instead.
Memoized variable @_remember_time_of_first_unprocessed_event does not match method name _wait_until_events. Use @_wait_until_events instead.
houndci-bot
reviewed
Nov 29, 2023
| @@ -85,11 +85,13 @@ def _deadline | |||
|
|
|||
| # blocks until event is popped | |||
| # returns the event or `nil` when the event_queue is closed | |||
| # rubocop:disable Naming/MemoizedInstanceVariableName | |||
There was a problem hiding this comment.
Lint/UnneededCopDisableDirective: Unnecessary disabling of Naming/MemoizedInstanceVariableName.
| @@ -38,7 +38,7 @@ def state(state_name, to: nil, &block) | |||
| end | |||
| end | |||
|
|
|||
| # Note: including classes must call initialize_fsm from their initialize method. | |||
| # NOTE: including classes must call initialize_fsm from their initialize method. | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [84/80]
| @@ -9,7 +9,7 @@ class Record | |||
| class SymlinkDetector | |||
| README_URL = 'https://github.com/guard/listen/blob/master/README.md' | |||
|
|
|||
| SYMLINK_LOOP_ERROR = <<-EOS | |||
| SYMLINK_LOOP_ERROR = <<-EOS.freeze | |||
There was a problem hiding this comment.
Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
|
Thanks for the PR, @AlexB52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #516
Rubocop version
0.91specified in the Gemfile isn't working for Ruby 3+ and the rake task fails locally.Upgrading Rubocop solves the problem.
I thought I'd take the opportunity to fix #516 since it's an open issue.