-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop workflow with GitHub actions #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Error: RuboCop found unknown Ruby version 3.0 in `TargetRubyVersion` paramete...
Error: RuboCop found unknown Ruby version 3.0 in `TargetRubyVersion` parameter (in .rubocop.yml). Supported versions: 2.4, 2.5, 2.6, 2.7, 2.8
include is used at the top level. Use inside class or module.
Annotation keywords like Note should be all upper case, followed by a colon, and a space, then a note describing the problem.
Freeze mutable objects assigned to constants
Avoid comparing a variable with multiple items in a conditional, use Array#include? instead.
Memoized variable @_remember_time_of_first_unprocessed_event does not match method name _wait_until_events. Use @_wait_until_events instead.
@@ -85,11 +85,13 @@ def _deadline | |||
|
|||
# blocks until event is popped | |||
# returns the event or `nil` when the event_queue is closed | |||
# rubocop:disable Naming/MemoizedInstanceVariableName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/UnneededCopDisableDirective: Unnecessary disabling of Naming/MemoizedInstanceVariableName.
@@ -38,7 +38,7 @@ def state(state_name, to: nil, &block) | |||
end | |||
end | |||
|
|||
# Note: including classes must call initialize_fsm from their initialize method. | |||
# NOTE: including classes must call initialize_fsm from their initialize method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics/LineLength: Line is too long. [84/80]
@@ -9,7 +9,7 @@ class Record | |||
class SymlinkDetector | |||
README_URL = 'https://github.com/guard/listen/blob/master/README.md' | |||
|
|||
SYMLINK_LOOP_ERROR = <<-EOS | |||
SYMLINK_LOOP_ERROR = <<-EOS.freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
Thanks for the PR, @AlexB52. |
Fix #516
Rubocop version
0.91
specified in the Gemfile isn't working for Ruby 3+ and the rake task fails locally.Upgrading Rubocop solves the problem.
I thought I'd take the opportunity to fix #516 since it's an open issue.