Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in stopping FSEvent runner #40

Merged
merged 1 commit into from
Dec 28, 2012
Merged

Fix race condition in stopping FSEvent runner #40

merged 1 commit into from
Dec 28, 2012

Commits on Dec 28, 2012

  1. Handle potential race condition when stopping 

    The race conditionn is the following. When a FSEvent#stop is called, it
kills the child process and closes the pipe. It can happen that the kill
signal is sent and then succesfully the pipe is closed, before the child
process dies and the pipe in the parent is closed.

This means that IO::select() can raise a Errno::EBADF if the file
descriptor is closed while waiting in select(). This additional rescue
makes sure we shutdown in this case just like any others. This is a much
more reliable solution than adding for example a sleep() between
Process.kill and @pipe.close in FSEvent#stop.

Found because of rubinius/rubinius#2102.
    @dbussink
    dbussink committed Dec 28, 2012
    Configuration menu
    Copy the full SHA
    75f1b9c View commit details
    Browse the repository at this point in the history