Skip to content

Commit

Permalink
Add buyer data to analytics where it's available
Browse files Browse the repository at this point in the history
Assuming that bid response has buyer data in format specified in
prebid#3115
  • Loading branch information
kelvin-chappell committed Feb 15, 2019
1 parent d67625d commit c84149d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 6 deletions.
19 changes: 15 additions & 4 deletions modules/guAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {ajax} from 'src/ajax';
* Update whenever you want to make sure you're sending the right version of analytics.
* This is useful when some browsers are using old code and some new, for example.
*/
const VERSION = 4;
const VERSION = 5;

const analyticsType = 'endpoint';
const SENDALL_ON = {};
Expand Down Expand Up @@ -135,9 +135,20 @@ function trackBidResponse(args) {
setSafely(event, 'sz', args.size);
setSafely(event, 'ttr', args.timeToRespond);
setSafely(event, 'lid', args.dealId);
setSafely(event, 'dsp', args.dspId);
setSafely(event, 'adv', args.advertiserId);
setSafely(event, 'add', args.advertiserDomain);

if (args.meta) {
setSafely(event, 'bri', args.meta.brandId);
setSafely(event, 'brn', args.meta.brandName);
}

// transitioning from old fields to new
const dspId = args.meta && args.meta.networkId ? args.meta.networkId : args.dspId;
setSafely(event, 'dsp', dspId);
const buyerId = args.meta && args.meta.buyerId ? args.meta.buyerId : args.advertiserId;
setSafely(event, 'adv', buyerId);
const clickUrl = args.meta && args.meta.clickUrl ? args.meta.clickUrl : args.advertiserDomain;
setSafely(event, 'add', clickUrl);

return [event];
}
return null;
Expand Down
13 changes: 11 additions & 2 deletions test/spec/modules/guAnalyticsAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,16 @@ describe('Gu analytics adapter', () => {
timeToRespond: 443,
size: '300x250',
dealId: 'd12345',
meta: {
networkId: 57,
buyerId: 36069,
brandId: 101,
brandName: 'biscuit',
clickUrl: 'blackrock.com'
},
dspId: 57,
advertiserId: 36069,
advertiserDomain: 'blackrock.com',
advertiserDomain: 'blackrock.com'
};

before(() => {
Expand Down Expand Up @@ -237,6 +244,8 @@ describe('Gu analytics adapter', () => {
adv: 36069,
dsp: 57,
add: 'blackrock.com',
bri: 101,
brn: 'biscuit'
});
});

Expand Down Expand Up @@ -318,7 +327,7 @@ describe('Gu analytics adapter', () => {
it('should have a version number', () => {
events.emit(CONSTANTS.EVENTS.BID_WON, BIDWONEXAMPLE);
const payload = JSON.parse(ajaxStub.firstCall.args);
expect(payload.v).to.be.equal(4);
expect(payload.v).to.be.equal(5);
});

it('should ignore responses sent with bid won event', () => {
Expand Down

0 comments on commit c84149d

Please sign in to comment.