Upgrade 7.26.0 #130
Merged
Upgrade 7.26.0 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle clicktrackers the ORTB way * support for clicktrackers on assets * parameters are now explicitly defined Co-authored-by: Michele Nasti <michele@rtk.io>
* Create Id Submodule for OneKey * Fix the 'decode' of OneKey Id * Refine the documentation of the OneKey Id Sub-Module * Update locations of the OneKey repositories in the Id sub-module doc
* Create RTD module for OneKey * Refine the documentation of the OneKey RTD Module * Update locations of the OneKey repositories in the RTD Provider doc
* User sync improvements * User sync improvements * Code review fixes * Pass supply chain to limelightDigitalBidAdapter.js Co-authored-by: apykhteyev <alex@project-limelight.com> Co-authored-by: EngineeringProjectLimeLight <45598299+EngineeringProjectLimeLight@users.noreply.github.com>
…idder support (prebid#8716) * Fledge POC: adding run ad auction and rendering with openxOrtbBidAdapter Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com> Co-authored-by: Luigi Sayson <luigi.sayson@openx.com> Co-authored-by: Kenan Gillet <kenan.gillet@openx.com> * Remove defensive coding: gtpSlotInfo is always an object * Change onBidderAuctionResponse callback to specialized onFledgeAuctionConfigs * openxOrtbBidAdapter: avoid error logging when response body is null ``` prebid.js:5 Prebid openx ERROR: Bidder openx failed to interpret the server's response. Continuing without bids null TypeError: Cannot use 'in' operator to search for 'nbr' in at prebid.js:12:4571 ``` Thanks @piotrj-rtbh * Fledge Modularized - make fledgeManager into a module - add top-level auction handling - add support for registering component auction to GPT ad slot - remove hard coded demo auction config, ensure auctionSignals is not undefined (#61) Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com> Co-authored-by: Luigi Sayson <luigi.sayson@openx.com> Co-authored-by: Kenan Gillet <kenan.gillet@openx.com> * Split GPT handling into its own module * Remove fledge run/rendered by prebid * Fix lint issues and name inconsistency * Update unit test after switching to GPT only * fix/remove no more relevant tests * fledgeForGpt: clarify documentation of configuration Co-authored-by: Laurentiu Badea <laurentiu.badea@openx.com> Co-authored-by: Luigi Sayson <luigi.sayson@openx.com>
* minor fixes * Update bidwatchAnalyticsAdapter.js * Update bidwatchAnalyticsAdapter.js
* forward advertiserDomains * Update bidwatchAnalyticsAdapter.js
* Yieldlab Bid Adapter support floor module, in order to set dynamic floor prices * comply with standard object-curly-spacing lint configuration
prebid#8864)" (prebid#8954) This reverts commit 5362745.
* update-ttl-passing * Update taboolaBidAdapter_spec.js * add fallback default value in case of null * add semicolons * . * . * . * .. * ... * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url
…e first and following request on multi request; added disableUserSyncs in order to disable that functionality as default and added the option to activate it from the bidRequest (prebid#8944)
* SpotX Adapter: Implement UID2 support * SpotX Adapter: Add UID2 Testing * Implement and Test Prebid userIdAsEids * Lint fix
…rebid#8901) * Add stage bidder service * add stage url * fix url * fix string method * clean up rebase * Adding transaction id and auction id. * Removing state url code * Clean up * Adding new line * Reading transaction id from impression. getting transaction id from imp.ext.tid Co-authored-by: elber@yieldmo.com <elber@yieldmo.com> Co-authored-by: Elber Carneiro <81249884+ym-elber@users.noreply.github.com>
Bumps [parse-path](https://github.com/IonicaBizau/parse-path) and [documentation](https://github.com/documentationjs/documentation). These dependencies needed to be updated together. Updates `parse-path` from 4.0.4 to 5.0.0 - [Release notes](https://github.com/IonicaBizau/parse-path/releases) - [Commits](IonicaBizau/parse-path@4.0.4...5.0.0) Updates `documentation` from 13.2.5 to 14.0.0 - [Release notes](https://github.com/documentationjs/documentation/releases) - [Changelog](https://github.com/documentationjs/documentation/blob/master/CHANGELOG.md) - [Commits](documentationjs/documentation@v13.2.5...v14.0.0) --- updated-dependencies: - dependency-name: parse-path dependency-type: indirect - dependency-name: documentation dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* New config parameter for a custom adserver domain * test fix * new test * pass userId object to bidder Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl>
* discovery Bid Adapter:new adapter * discovery Bid Adapter:new adapter * fix lint * change bidder name & fix circleCI lint * fix lint * fix lint * add bidWon report * delete package-lock.json * update discoveryBidAdapter * add meta.advertiserDomains * Optimisation bidResponse * fix Spelling errors :( * add ttl into bidResponse :( * kick off circleci tests manually * for kick off circleci * update markdown * Update discoveryBidAdapter.md * kick off tests * fix linting Co-authored-by: v_cuidong <v_cuidong@baidu.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* Bump dset from 2.0.1 to 3.1.2 Bumps [dset](https://github.com/lukeed/dset) from 2.0.1 to 3.1.2. - [Release notes](https://github.com/lukeed/dset/releases) - [Commits](lukeed/dset@v2.0.1...v3.1.2) --- updated-dependencies: - dependency-name: dset dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update utils.js Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* Captify Live-classification Rtd Submodule * Fix code-review comments
* add video support * Sync URL was changed
* create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * support storageAllowed restriction on unit tests for prebid 7 * add it also to the aftereach * add it also to the aftereach * change the api endpoint https protocol * update Taboola prebid documentation: tagId, publisherId, bidFloor. * update bid response ttl to 60 seconds. * update Taboola prebid documentation. * update-ttl-passing * Update taboolaBidAdapter_spec.js * add fallback default value in case of null * add semicolons * . * . * . * .. * ... * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * optional-chaining * set netRevenue to true. * fix bid response in case we have multiple impressions * add test * fix lint * unsupport-dynamic-endpoint Co-authored-by: Michael <michael.ziso@taboola.com> Co-authored-by: mikiz <31058500+mikizi@users.noreply.github.com> Co-authored-by: jenny.l <jenny.l@taboola.com> Co-authored-by: jennylt <48404417+jennylt@users.noreply.github.com> Co-authored-by: Shakhal Levinson <shakhal.l@taboola.com> Co-authored-by: shakhaltb <108469576+shakhaltb@users.noreply.github.com>
…prebid#9213) * Discard bid response if ad and adUrl empty * Restore removeAll in U.T. * Restore one more removeAll
Co-authored-by: pm-azhar-mulla <azhar@L1119.local>
* Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix * Out-Stream render update to SmartPlay 5.2 * ESlint fix * ESlint fix * ESlint fix * adjust tests, fixes * ESlint * adjusted desired bitrate examples * added bid.meta.advertiserDomains support * bug fix for numeric elementID outstream render * fix renderer url * support for floors module * bugfixes to be openRTB 2.5 compliant * update internal renderer usage * remove unused outstream_function logic * bugfix outstream options for default outstream renderer configuration * [PREB-10] fix empty title not configurable * add pbjs version * testing with outstream 5.3.0 * pbjs version into content.ext * made visibilityThreshold configurable * adjust position of pbjs version * Merge branch 'master' of https://github.com/prebid/Prebid.js into HEAD * update smartclip outstream player version to support outstream 6 release along with necessary config changes * Add support for schain * vacuuming Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> Co-authored-by: smartclip-adtech <65160328+smartclip-adtech@users.noreply.github.com>
* Mediago Bid Adapter:new adapter * remove console * change spec file to fix CircleCI * change spec file to fix CircleCI * change spec file * Update mediagoBidAdapter.js * Update mediagoBidAdapter.js * rerun CurcleCi * update mediagoBidAdapter * update discoveryBidAdapter Co-authored-by: BaronYu <baronwei11@gmail.com>
…9231) * Smartadserver Bid Adapter: Add support for SDA user and site * Smartadserver Bid Adapter: Fix SDA support getConfig and add to unit testing Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com>
* feat(module): multi size request * fix getUserSyncs added tests * update(module): package-lock.json from master * feat(module): VidazooBidAdapter - send top query params to server * added bid.getFloor handler Co-authored-by: roman <shmoop207@gmail.com> Co-authored-by: Saar Amrani <89377180+saar120@users.noreply.github.com> Co-authored-by: Saar Amrani <saar120@gmail.com>
* add viqeo prebid adapter * added bid params to docs * updated to Outstream * updated to Outstream (tests)
* Don't know why params are in an array in that bid object. Make it work for both if it is fixed later * Update params reading method to adapt to arrays for all params * Keywords have to be an array of string (#9) * Keywords have to be an array of string * Last check if isStr * Fix linting errors * Fix tests
…the /hbjson request (prebid#9214)
* Fix: creating host correctly when http or https are added from the beginning * Fix :: Changed double quotes for single quotes * Fix :: Getting the full page URL * Fix :: Changed order params * Fix :: Replaced quotes from double to simple * Fix :: Adapting format to lint * Remove TODO comment * Added more controls * camelcase fix * Changed test * Remove "inIframe" util Co-authored-by: Jordi Arnau <jarnau@tappx.com> Co-authored-by: ruben_tappx <rcaparros@tappx.com>
17 tasks
chrislomaxjones
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Upgrades to
7.26.0Changes as per (https://github.com/guardian/Prebid.js/blob/main/GUARDIAN_modifications.md):
trustxBidAdapteris now an alias ofgridBidAdapter(Prebid 7: TheMediaGrid: make trustxBidAdapter as alias of gridBidAdapter prebid/Prebid.js#8321) swap inmodules.jsonbabelConfig.js, that needs to be used in the webpack babel override for@guardian/libsdist/prebid.jsby running:npm run build