This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
chore: Update @actions/core to v1.6.0 and remove node-fetch
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the release notes v1.6.0: > Added OIDC Client function `getIDToken` This means we no longer need to manually do this and can remove the `node-fetch` dependency. See https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#160
akash1810
added a commit
that referenced
this pull request
Sep 29, 2021
We were previously reading these environment variables in order to manually fetch a token. Since #17, we're using the functionality provided by `@actions/core` to do this, so we no longer need to read these environment variables as we're not using them.
Merged
akash1810
added a commit
that referenced
this pull request
Sep 29, 2021
We were previously reading these environment variables in order to manually fetch a token. Since #17, we're using the functionality provided by `@actions/core` to do this, so we no longer need to read these environment variables as we're not using them. This is a `fix` because `getEnvString` will no longer throw unnecessarily.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
From the release notes v1.6.0:
This means we no longer need to manually do this and can remove the
node-fetchdependency.See https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#160
How to test
The integration tests should pass.
How can we measure success?
Less code and fewer dependencies!