This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
pull upstream@2.4 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alejandro Pauly <alepauly@github.com>
* first iteration for implementation of caching * add logs * add debug line * fix build command * fix path * add possible post-if * remove braces * test new action post-if variant * work on built-in caching * remove post-if * pass version * work on yarn support * fix return value * change names and remove logs * worked on resolving comments * check post-if for null * add success() condition * remove primary key field * work on resolving comments * remove logs * resolving comments * resolving comments * resolving comments * resolving comments * fix getpackageManagerVersion * run clean for unstaged changes * fix falling version tests * work on resolving comments * resolving comments * fix comment * resolve comments * Add tests to cover node's caching (#3) * add tests to cover node's caching * work on fixing tests * fix e2e tests * rebuild and fix test * fixing tests * change name of describes, it and fix test * add names for jobs * fix issue
commit 446068a Author: Alena Sviridenko <alenasviridenko@github.com> Date: Tue Jun 22 17:51:35 2021 +0300 updated headers commit d7e254e Author: Alena Sviridenko <alenasviridenko@github.com> Date: Thu Jun 17 17:35:34 2021 +0300 updated links commit ffd9956 Author: AlyonaSviridenko <alenasviridenko@github.com> Date: Thu Jun 17 17:33:41 2021 +0300 Added advanced usage commit 1e068f0 Author: AlyonaSviridenko <alenasviridenko@github.com> Date: Thu Jun 17 15:07:42 2021 +0300 Updated readme with caching commit 7528c33 Author: Maxim Lobanov <v-malob@microsoft.com> Date: Wed Jun 16 14:43:46 2021 +0300 Update versions.yml
Create ADR for integrating cache functionality to setup-node action
* regenerate license * npm run build * sync branches * rebuild project * fix test Co-authored-by: Dmitry Shibanov <dmitry-shibanov@github.com>
Add pnpm caching support
…age-temp-v2 Temporarily disabled cache usage for v2
…le-cache-usage-temp-v2 Revert "Temporarily disabled cache usage for v2"
ADR for support caching for mono repos and repositories with complex structure
…o mazhuk/adding-support-for-monorepos
…t-for-monorepos Support caching for mono repos and repositories with complex structure
…tream-version # Conflicts: # README.md # dist/index.js # package-lock.json
sndrs
force-pushed
the
pull-2.4-upstream-version
branch
from
1501c9a to
96a9274
Compare
sndrs
requested review from
SiAdcock,
JamieB-gu and
a team
and removed request for
SiAdcock
|
I ran Licensed locally to update the cached license files. There were three that were parsed as It does seem like this is including devDependencies too. I'm not sure if we can/should be ignoring those but at least this check is now passing. |
|
i've added it to https://github.com/guardian/source-shakedown and it looks good – caching is also super fast |
SiAdcock
approved these changes
Sep 24, 2021
|
pushed these changes to actions#239 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulls the upstream changes up to current main (2.4) and tags main accordingly