feat: Use GuCDK's log shipping policy construct #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa-replace-ssm-policy
branch
from
443187b to
342d83a
Compare
akash1810
force-pushed
the
aa-replace-log-shipping-policy
branch
from
4bcaccd to
f1bf258
Compare
jacobwinch
approved these changes
Jun 21, 2021
akash1810
force-pushed
the
aa-replace-ssm-policy
branch
from
342d83a to
e8e02da
Compare
This change replaces the YAML defined log shipping policy with the GuCDK's `GuLogShippingPolicy` construct. `GuLogShippingPolicy` also brings a Parameter Store driven parameter into the stack, which replaces `KinesisStreamName`.
akash1810
force-pushed
the
aa-replace-log-shipping-policy
branch
from
f1bf258 to
c695e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #600 and #598.
What does this change?
This change replaces the YAML defined log shipping policy with the GuCDK's
GuLogShippingPolicyconstruct.GuLogShippingPolicyalso brings a Parameter Store driven parameter into the stack, which replacesKinesisStreamName.How to test
How can we measure success?
We move closer to a CDK only template.