Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snyk workflow #698

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Add Snyk workflow #698

merged 4 commits into from
Feb 28, 2022

Conversation

jacobwinch
Copy link
Contributor

@jacobwinch jacobwinch commented Feb 18, 2022

What does this change?

This PR uses the department-wide Snyk workflow, which helps us to identify vulnerabilities that would be missed by the current integration. This is because the former uses the Snyk cli, whereas the latter relies on the GitHub integration, which is not particularly accurate for sbt projects.

Whilst working on this, we noticed that .nvmrc was in a slightly odd place, so it's been moved to the project root as part of this change.

@jacobwinch jacobwinch marked this pull request as ready for review February 25, 2022 09:59
@jacobwinch jacobwinch requested a review from a team February 25, 2022 09:59
@jacobwinch jacobwinch merged commit e51819f into main Feb 28, 2022
@jacobwinch jacobwinch deleted the jw-snyk branch February 28, 2022 09:18
@jacobwinch
Copy link
Contributor Author

I've now deleted the project that was using the GitHub integration, so that we have a single project in Snyk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants