-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt GHA Scala Library Release Workflow & use Sonatype token rather than password #90
Conversation
|
This is definitely moving in the right direction - just to point out, two things are changing in this PR:
Note that I suggest that this repo should switch to using |
fd42177
to
b8eee77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we can only really try this out by merging and trying to do a release.
We needed a couple of fix-ups to get this working (#91 & #92) but we've now successfully released v10.0.0, which was a simultaneous release for NPM & Scala 👍 NPMWe can see that the produced number of files and total filesize is similar for both our new release and the previous 9.0.0 release: https://www.npmjs.com/package/@guardian/apps-rendering-api-models/v/10.0.0 https://www.npmjs.com/package/@guardian/apps-rendering-api-models/v/9.0.0 Scalahttps://index.scala-lang.org/guardian/apps-rendering-api-models/artifacts/apps-rendering-api-models |
Two changes: * A new 'Release' badge, linking straight to the Release workflow added in #90 - a quick way to get to the place where you can make a release, and a status indicator showing if the last release failed. * Update the NPm badge to link to the project on npmjs.com, which is always convenient when debugging builds
Co-authored with @rtyley
What does this change?
Our release recently failed due to a change in authentication for Sonatype.
This PR fixes the release process while moving from changesets to gha-scala-library-release-workflow, which is our preferred method for releasing Scala library versions.