Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt GHA Scala Library Release Workflow #93

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Jan 9, 2024

Here we're switching from using actions-sbt-release to gha-scala-library-release-workflow for publishing releases of this library - see also guardian/actions-sbt-release#1 for details on why we want to make this move.

A fair bit of sbt configuration is deleted or changed - see the docs on config changes for more information, and enjoy the decreased line-count! ✨

image

I'd be very happy to pair with anyone who wants to walk through this PR or try out the release process for themselves - please do let me know if you've got any questions!

Once this PR is merged, we should also delete the old repository secrets:

image

@rtyley rtyley force-pushed the adopt-gha-scala-library-release-workflow branch from 0539bd6 to 12b92a8 Compare January 9, 2024 10:59
Here we're switching from using `actions-sbt-release` to
`gha-scala-library-release-workflow` for publishing releases of this
library - see also guardian/actions-sbt-release#1.

A fair bit of sbt configuration is deleted or changed - see the docs on
config changes for more information:

https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md

Once this PR is merged, we should also delete the old repository secrets:

https://github.com/guardian/atom-maker/settings/secrets/actions
@rebecca-thompson rebecca-thompson merged commit 5006764 into main Jan 17, 2024
2 checks passed
rtyley added a commit that referenced this pull request Jan 17, 2024
After #93 we found that
unfortunately the Release workflow failed while running the tests:

* The Release workflow uses Java 17 for all builds
* The Atom Maker library uses Play with Guice for Dependency Injection
* Guice gained Java 17 & 21 support with Guice v6:
  https://github.com/google/guice/wiki/Guice600
* Play only updated to Guice v6 (and gained general Java 17 support)
  with Play v2.9:
  playframework/playframework#11808
  playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
rtyley added a commit that referenced this pull request Jan 17, 2024
After #93 we found that
unfortunately the Release workflow failed while running the tests:

* The Release workflow uses Java 17 for all builds
* The Atom Maker library uses Play with Guice for Dependency Injection
* Guice gained Java 17 & 21 support with Guice v6:
  https://github.com/google/guice/wiki/Guice600
* Play only updated to Guice v6 (and gained general Java 17 support)
  with Play v2.9:
  playframework/playframework#11808
  playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
rtyley added a commit that referenced this pull request Jan 18, 2024
After #93 we found that
unfortunately the Release workflow failed while running the tests:

* The Release workflow uses Java 17 for all builds
* The Atom Maker library uses Play with Guice for Dependency Injection
* Guice gained Java 17 & 21 support with Guice v6:
  https://github.com/google/guice/wiki/Guice600
* Play only updated to Guice v6 (and gained general Java 17 support)
  with Play v2.9:
  playframework/playframework#11808
  playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants