update GuRole import in instance role #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates the import of
GuRole
in theinstance-role.ts
file to import directly from theroles.ts
file rather than theindex.ts
in theroles
directory as this was causing an error when importing anything from@guardian/cdk/lib/constructs/iam
.Does this change require changes to existing projects or CDK CLI?
Any projects importing
GuInstanceRole
orGuRole
from their specific file will now be able to get them from the@guardian/cdk/lib/constructs/iam
path.How to test
Bump to the latest version and try importing the
GuInstanceRole
construct from@guardian/cdk/lib/constructs/iam
How can we measure success?
All imports work as expected.