Commits on May 19, 2021

1. chore: Remove linting from integration-test project …

   Version 2.23.2 of `eslint-plugin-import` prefers to `import` statements
   above `import type`.
   
   We do not have a lockfile for the `integration-test` project because:
   
   > Ignore package-lock.json to avoid the following error when reinstalling dependencies:
   > npm ERR! notarget No matching version found for eslint-plugin-custom-rules@1.0.0.
   > This is because we're installing @guardian/cdk from file, which is in turn installing eslint-plugin-custom-rules from file.
   
   Combined this with the version of `eslint-plugin-import` is defined with `^`,
   linting is non-deterministic* and we only saw an import order linting error locally
   after removing `node_modules`.
   
   There are a couple of ways to improve this:
     - Work out how to use a lockfile in the integration-test
     - Remove linting and hope the other dependencies using `^` versions are OK
   
   This change removes linting, with the justification that:
     - This project is never consumed by anyone
     - This project doesn't run anywhere
     - This project doesn't get updated too often
     - Understanding the original lockfile issues is a time sink
   
   See:
     - import-js/eslint-plugin-import#2021
     - #564
   
   * Well, the entire build of integration-test is non-deterministic!

   

   akash1810 committed May 19, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 9da786b
   • Browse repository at this point

   Copy the full SHA

   9da786b View commit details

   Browse the repository at this point in the history

2. chore: Add a note to the README for lint change

   

   akash1810 committed May 19, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for cad2bf9
   • Browse repository at this point

   Copy the full SHA

   cad2bf9 View commit details

   Browse the repository at this point in the history