Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update typescript skeleton #30

Merged
merged 1 commit into from
Mar 16, 2020
Merged

update typescript skeleton #30

merged 1 commit into from
Mar 16, 2020

Conversation

akash1810
Copy link
Member

  • Failing test by default
  • ./script/setup to install things
  • ./script/test to run tests

@akash1810
update typescript skeleton
96e62ee 
- Failing test by default
- `./script/setup` to install things
- `./script/test` to run tests
mbarton
mbarton reviewed Mar 13, 2020
View reviewed changes
typescript/script/test

set -e

yarn test --watch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried this from scratch I got --watch is not supported without git/hg

Copy link
Contributor

@jonathonherbert jonathonherbert Mar 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, a fresh clone and this seems fine for me – it looks like jest needs a git context, but I can't see how this wouldn't already be present

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing it on Linux in a Chromebook so it was probably something unusual about my setup. Happy to let this go through and we can adjust if anyone hits it IRL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to let this go through and we can adjust if anyone hits it IRL

👍I've a TS interview on Monday which will provide another data point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for me to merge this this morning? Got an interview at 12 today 😬 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep merge away

@jonathonherbert
Copy link
Contributor

Approved to unblock, we can correct later if necessary.

@akash1810 akash1810 merged commit 2b0f627 into master Mar 16, 2020
@akash1810 akash1810 deleted the aa-public-typescript branch March 16, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarton mbarton mbarton left review comments

@jonathonherbert jonathonherbert jonathonherbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akash1810 @jonathonherbert @mbarton