Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EnricoMi error on failing CI #416

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

Fweddi
Copy link
Contributor

@Fweddi Fweddi commented Apr 3, 2024

What does this change?

This test workflow intermittently fails: https://github.com/guardian/content-api-scala-client/actions/runs/8540280736/job/23397082405?pr=414.

Upgrading EnricoMi seems to fix this flakiness (see https://github.com/guardian/apple-news/pull/320).

@Fweddi Fweddi requested a review from a team as a code owner April 3, 2024 15:05
@Fweddi Fweddi mentioned this pull request Apr 3, 2024
Copy link
Contributor

@Divs-B Divs-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@Fweddi Fweddi merged commit d5b23cb into main Apr 3, 2024
2 checks passed
@Fweddi Fweddi deleted the fp/fix-enricomi-error-in-failing-ci branch April 3, 2024 15:10
Divs-B added a commit that referenced this pull request Apr 19, 2024
As mentioned in EnricoMi documentation https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#permissions

We have to set the permission which we have missed in last PR where we have updated Enricomi v1 to v2 : #416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants