Add .nvmrc file as specified for setup-node action #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR #32, we specified node-version-file in release.yml file to use .nvmrc file but we didn't add the file and hence got failed on NPM release. ref: https://github.com/guardian/content-entity/actions/runs/8360348474
|
@Divs-B has published a preview version of this PR with release workflow run #3, based on commit 464e7da: 3.0.1-PREVIEW.db-rtadd-nvmrc-file-for-release.2024-03-20T1430.464e7dae Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the db-rt/add-nvmrc-file-for-release branch, or use the GitHub CLI command: gh workflow run release.yml --ref db-rt/add-nvmrc-file-for-release Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
rtyley
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
In this PR #32, we specified node-version-file in release.yml file to use .nvmrc file but we didn't add the file and hence got failed on NPM release. ref: https://github.com/guardian/content-entity/actions/runs/8360348474
How to test
Make a preview/production release to check NPM release as well this time
How can we measure success?
NPM release should go successfully.