Temporary disable compatibility check on releases #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by Roberto we can disable the releases checks to make succesful release this time, the release process is currently trying to find thrift latest release of 3.0.1 which is not available hence we will disable release comparison and make the release and then will enable again once releases goes well. #36 (comment)
rtyley
approved these changes
Mar 26, 2024
|
Release is done with no error this time. 
|
Divs-B
added a commit
that referenced
this pull request
Mar 26, 2024
As we got successful releases after PR #38 we can now put back AssessedCompatibilityWithLatestReleas in our sbt file.
Brilliant! Don't forget to revert this PR now - and then do another release afterwards, which should now succeed! |
Ah good spot! Thank you for reminding that we can revert this PR to get back the change we want and no need to extra PR for that. |
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @rtyley we can disable the releases checks to make succesful release this time, the release process is currently trying to find thrift latest release of 3.0.1 which is not available due to missed thing in PR #32 which got fixed in PR #36.
To fix the releases we will disable release comparison and make the release and then will enable again once releases goes well.
#36 (comment)
How to test
once this gets merged we will make release
How can we measure success?
release should go well