Simplify the build pipeline #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9275d89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
🛠 workspace
📦 npm
sndrs
changed the title
pkgroll to local distpkgroll to local dist
sndrs
commented
Apr 26, 2024
sndrs
commented
Apr 29, 2024
sndrs
commented
Apr 29, 2024
sndrs
added
the
🐥 Canaries
sndrs
changed the title
pkgroll to local dist
This was
linked to
issues
May 7, 2024
sndrs
added
the
🐥 Canaries
sndrs
removed
the
🐥 Canaries
oliverabrahams
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
updates the build/packages setup:
rollupdirectly@csnx/npm-packagerollup-plugin-esbuildandrollup-plugin-dtsin place ofrollup-plugin-tsdistdirs and removes thepathsconfig fromtsconfigbuildandvalidate-disttasks from packages that don't actually build anything (were just being copied to Nx's rootdistdir)Why?
All packages that depend on sibling packages in the repo now consume their real
distfiles, not.tssource files.it also surfaces the rollup config and package.json for each package more clearly.
our previous typescript plugin created some weird type issues (we think it was the plugin).
rollup-plugin-dtsis more commonly used hopefully more robust!Why is it so big?
we'd accumulated some tech debt that made each of these steps difficult to do alone - this was pairing/mobbing effort the whole team was involved in, so in effect it was reviewed in real time.
Co-authored-by: @oliverabrahams
Co-authored-by: @jamesmockett