Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 64px headline typography presets #1550

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Add 64px headline typography presets #1550

merged 4 commits into from
Jun 18, 2024

Conversation

jamesmockett
Copy link
Contributor

@jamesmockett jamesmockett commented Jun 17, 2024 •
edited
Loading

What are you changing?

  • Adds 64px variant of headline typography presets and removes 70px variant
headlineBold64
headlineLight64
headlineLightItalic64
headlineMedium64
headlineMediumItalic64
Screenshot 2024-06-17 at 16 54 59

Why?

  • Maintains parity with presets in Figma and supports new use cases
  • The 70px variant had been erroneously added

@jamesmockett jamesmockett requested review from a team as code owners June 17, 2024 15:52
@jamesmockett jamesmockett self-assigned this Jun 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4d67fe9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@jamesmockett jamesmockett added run_chromatic Runs chromatic when label is applied and removed 📦 npm Affects a @guardian package on NPM labels Jun 17, 2024
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jun 17, 2024
@jamesmockett jamesmockett requested review from a team as code owners June 17, 2024 16:02
@jamesmockett jamesmockett merged commit dc79048 into main Jun 18, 2024
18 checks passed
@jamesmockett jamesmockett deleted the jm/update-headline-presets branch June 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees

@jamesmockett jamesmockett

Labels
🎨 Design System 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmockett @sndrs