Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency web-vitals to v3.0.0 #309

Merged
merged 18 commits into from
Feb 2, 2023
Merged

Update dependency web-vitals to v3.0.0 #309

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
21ab322
Update dependency web-vitals to v3
renovate[bot] Dec 15, 2022
a316e6b
Merge branch 'main' into renovate/web-vitals-3.x
joecowton1 Jan 9, 2023
2514d4a
Merge branch 'main' into renovate/web-vitals-3.x
joecowton1 Feb 2, 2023
57adc74
Update dependency web-vitals to v3
renovate[bot] Feb 2, 2023
e8e67ff
Add report config object
Feb 2, 2023
ffd99ec
Merge branch 'renovate/web-vitals-3.x' of github.com:guardian/csnx in…
Feb 2, 2023
3369224
add changeset
Feb 2, 2023
7cf6de5
Update libs/@guardian/core-web-vitals/package.json
joecowton1 Feb 2, 2023
6b6c72d
Update libs/@guardian/core-web-vitals/package.json
joecowton1 Feb 2, 2023
8a7ffa6
remove cwv from source packages
Feb 2, 2023
5af5ba4
Update pnpm.lock
Feb 2, 2023
18d30d6
Use `onXXX` method names from `web-vitals` (#397)
mxdvl Feb 2, 2023
ebd7e17
Revert method names
Feb 2, 2023
6b2280a
Update .changeset/tasty-mayflies-flash.md
joecowton1 Feb 2, 2023
879e138
Update tasty-mayflies-flash.md
joecowton1 Feb 2, 2023
c0a1c78
Update tasty-mayflies-flash.md
joecowton1 Feb 2, 2023
a897bfc
Update tasty-mayflies-flash.md
joecowton1 Feb 2, 2023
1b62c14
Merge branch 'main' into renovate/web-vitals-3.x
joecowton1 Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-mayflies-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@guardian/core-web-vitals': major
---

Update to use web-vitals v3
joecowton1 marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions libs/@guardian/core-web-vitals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"@guardian/libs": "12.0.0",
"tslib": "2.4.1",
"typescript": "4.3.2",
"web-vitals": "2.0.0"
"web-vitals": "3.0.0"
},
"peerDependencies": {
"@guardian/libs": "^12.0.0",
"tslib": "^2.4.1",
"typescript": "^4.3.2",
"web-vitals": "^2.0.0"
"web-vitals": "^3.0.0"
joecowton1 marked this conversation as resolved.
Show resolved Hide resolved
},
"peerDependenciesMeta": {
"typescript": {
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/core-web-vitals/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const getCoreWebVitals = async (): Promise<void> => {
const webVitals = await import('web-vitals');
const { getCLS, getFCP, getFID, getLCP, getTTFB } = webVitals;
joecowton1 marked this conversation as resolved.
Show resolved Hide resolved

getCLS(onReport, false);
getCLS(onReport, { reportAllChanges: false });
getFID(onReport);
getLCP(onReport);
getFCP(onReport);
Expand Down
3 changes: 1 addition & 2 deletions libs/@guardian/eslint-plugin-source-foundations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"@types/estree": "0.0.51",
"eslint": "8.0.0",
"tslib": "2.4.1",
"typescript": "4.3.2",
"web-vitals": "2.0.0"
"typescript": "4.3.2"
},
"peerDependencies": {
"@guardian/libs": "^12.0.0",
Expand Down
3 changes: 1 addition & 2 deletions libs/@guardian/eslint-plugin-source-react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"eslint": "8.0.0",
"react": "17.0.1",
"tslib": "2.4.1",
"typescript": "4.3.2",
"web-vitals": "2.0.0"
"typescript": "4.3.2"
},
"peerDependencies": {
"@guardian/libs": "^12.0.0",
Expand Down
3 changes: 1 addition & 2 deletions libs/@guardian/source-react-components-development-kitchen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
"@types/react": "17.0.1",
"react": "17.0.1",
"tslib": "2.4.1",
"typescript": "4.3.2",
"web-vitals": "2.0.0"
"typescript": "4.3.2"
},
"peerDependencies": {
"@emotion/react": "^11.0.0",
Expand Down
17 changes: 7 additions & 10 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.