-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ArticleDesign.PrintShop
#12264
Open
JamieB-gu
wants to merge
4
commits into
main
Choose a base branch
from
remove-print-shop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 2, 2024
JamieB-gu
force-pushed
the
remove-print-shop
branch
from
September 2, 2024 12:01
da97650
to
6441170
Compare
Size Change: -135 B (-0.02%) Total Size: 898 kB ℹ️ View Unchanged
|
We no longer intend to handle this as a separate `ArticleDesign`. Anything that was previously `PrintShop` will now be one of the other `ArticleDesign`s. Removed print shop parsing, fixtures, and stories. Also removed the corresponding frontend type, which frontend will no longer be sending to DCAR. Using a pre-release version for now.
JamieB-gu
force-pushed
the
remove-print-shop
branch
from
September 16, 2024 10:40
6441170
to
a553182
Compare
This type has been migrated to DCAR from `guardian/libs`.
AR is now using its own implementation of `ArticleFormat`.
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 11, 2024
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer intend to handle this as a separate
ArticleDesign
. Anything that was previouslyPrintShop
will now be one of the otherArticleDesign
s.Removed print shop parsing, fixtures, and stories. Also removed the corresponding frontend type, which frontend will no longer be sending to DCAR.