-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Avatar
Stories To Match Others In The Codebase
#12538
Open
JamieB-gu
wants to merge
2
commits into
main
Choose a base branch
from
update-avatar-stories-to-match
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 11, 2024
Size Change: 0 B Total Size: 898 kB ℹ️ View Unchanged
|
Using `satisfies` gives better type safety for args. Removed the custom `splitTheme` wrapper decorator to prefer the "global colour scheme" toolbar item, which also means replacing the custom `theme` parameter with the `formats` parameter. Made use of CSFv3 to reuse story properties.
JamieB-gu
force-pushed
the
update-avatar-stories-to-match
branch
from
October 11, 2024 15:49
00c89fd
to
5c596bb
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 11, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
satisfies
gives better type safety for args1. Removed the customsplitTheme
wrapper decorator to prefer the "global colour scheme" toolbar item, which also means replacing the customtheme
parameter with theformats
parameter. Made use of CSFv3 to reuse story properties2.Footnotes
https://storybook.js.org/docs/writing-stories/typescript#using-satisfies-for-better-type-safety ↩
https://storybook.js.org/docs/writing-stories#how-to-write-stories ↩