-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BigNumber
Stories To Component Story Format v3
#12540
Open
JamieB-gu
wants to merge
1
commit into
main
Choose a base branch
from
csf-v3-big-number
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the default for Storybook 7+, and integrates better with some of its features. Using `satisfies` gives better type safety for args. Replaced the function-based story with the CSFv3 `render` method. Removed the `splitTheme` decorator, as this is now handled by the "global colour scheme" toolbar item and a Chromatic mode. As there's only one story, renamed the story to have the same name as the component, which allows storybook to hoist the story in the UI.
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 11, 2024
Size Change: 0 B Total Size: 898 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default for Storybook 7+, and integrates better with some of its features1.
Using
satisfies
gives better type safety for args2. Replaced the function-based story with the CSFv3render
method3. Removed thesplitTheme
decorator, as this is now handled by the "global colour scheme" toolbar item4 and a Chromatic mode5. As there's only one story, renamed the story to have the same name as the component, which allows storybook to hoist the story in the UI6.Footnotes
https://storybook.js.org/blog/storybook-csf3-is-here/ ↩
https://storybook.js.org/docs/writing-stories/typescript#using-satisfies-for-better-type-safety ↩
https://storybook.js.org/docs/api/csf#custom-render-functions ↩
https://storybook.js.org/docs/essentials/toolbars-and-globals ↩
https://www.chromatic.com/docs/modes/ ↩
https://storybook.js.org/docs/writing-stories/naming-components-and-hierarchy#single-story-hoisting ↩