Add Play v2.9 support to aid Facia Tool upgrade #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether you get benefit from going 2.8->2.9->3.0 (over just going 2.8->3.0) is probably a factor of how big and complicated the project being upgraded is - I'd guess Facia Tool is quite big, so breaking the changes down into smaller chunks might be worth it in terms of avoiding risk. Note also that Play 2.9 actually uses Play-Json *2.10*, which is a bit surprising! See also guardian/maintaining-scala-projects#4
rtyley
commented
Feb 28, 2024
| @@ -27,6 +27,7 @@ object Dependencies { | |||
| object PlayJsonVersion { | |||
| val V27 = PlayJsonVersion("27", "com.typesafe.play", "2.7.4") | |||
| val V28 = PlayJsonVersion("28", "com.typesafe.play", "2.8.2") | |||
| val V29 = PlayJsonVersion("29", "com.typesafe.play", "2.10.4", supportsScala3 = true) | |||
There was a problem hiding this comment.
The supportsScala3 flag isn't actually used here - but it doesn't mean it requires Scala 3! Just that, in principle, we could create Scala 3 artifacts for this version.
As #307 introduces a new artifact, unfortunately artifact compatibility checking will crash out (reporting that it can't find the previous version of the brand new artifact to check compatibility against). So, we have to disable the check for now, and then revert this change after the new artifact is released.
Fweddi
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether you get benefit from going 2.8→2.9→3.0 (over just going 2.8→3.0) is probably a factor of how big and complicated the project being upgraded is (see also guardian/maintaining-scala-projects#4) - I'd guess Facia Tool is quite big, so breaking the changes down into smaller chunks might be worth it in terms of avoiding risk.
Obviously we're encouraging people to get onto Play 3.0 to avoid the Akka BSL licensing issue!
Note also that Play 2.9 actually uses Play-Json 2.10, which is a bit surprising!