Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Europe edition to findBranding function #324

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

emma-imber
Copy link
Contributor

@emma-imber emma-imber commented Sep 24, 2024

What does this change?

Adds the Europe edition ID "eur" to the editions mapped over in the findBranding function. This should mean that edition branding will now be added for the Europe edition. This will enable the correct styling of labs containers and cards when the Europe edition is selected.

Tested on CODE and the EditionBranding now pulls through for "EUR" correctly:

Screenshot 2024-09-24 at 15 55 28

@gu-scala-library-release
Copy link
Contributor

@emma-imber has published a preview version of this PR with release workflow run #35, based on commit 4707cdf:

10.0.1-PREVIEW.eiadd-branding-eur-edition.2024-09-24T1202.4707cdf8

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ei/add-branding-eur-edition branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ei/add-branding-eur-edition

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@emma-imber emma-imber marked this pull request as ready for review September 24, 2024 14:58
@emma-imber emma-imber merged commit 4f2a883 into main Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants