Add Europe edition to findBranding function #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emma-imber has published a preview version of this PR with release workflow run #35, based on commit 4707cdf: 10.0.1-PREVIEW.eiadd-branding-eur-edition.2024-09-24T1202.4707cdf8 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ei/add-branding-eur-edition branch, or use the GitHub CLI command: gh workflow run release.yml --ref ei/add-branding-eur-edition Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
arelra
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the Europe edition ID "eur" to the editions mapped over in the findBranding function. This should mean that edition branding will now be added for the Europe edition. This will enable the correct styling of labs containers and cards when the Europe edition is selected.
Tested on CODE and the EditionBranding now pulls through for "EUR" correctly: